#73 Set-Cookie header incompatible with current Rack spec - Thin

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:id	tickets sorted by id (creation time)
Combine keywords for powerful searching.
Use advanced searching »

#73 √ resolved

Set-Cookie header incompatible with current Rack spec

Reported by Pedro Belo | June 30th, 2008 @ 04:34 PM | in 1.0

Using Thin + Rack::Adapter::Rails + Lint won't work if you have two cookies being set in the same response.

The problem is Rack::Adapter::Rails is joining the cookies with a newline, which is not accepted in the current Lint implementation.

macournoyer July 1st, 2008 @ 09:47 AM
- → Milestone changed from “Future” to “1.0”
- → State changed from “new” to “open”
macournoyer July 1st, 2008 @ 09:47 AM
thx for the patch Pedro, I'll apply and test when I get a minute
macournoyer July 1st, 2008 @ 10:51 PM
hm not sure about it. Like christian said:
```
"Set-Cookie" => [cookie1.to_s, cookie2.to_s]  works in current Rack. 
In future Racks (for 1.9 support, not yet fully specified), the 
newline is the correct way. 
```
The newline is the correct way in 1.9, not sure if this is gonna end up the correct way for both version.
macournoyer July 14th, 2008 @ 12:03 AM
- → State changed from “open” to “resolved”
(from [34da9ea800d4667a8a15700610ffc9fff71b9806]) Make Set-Cookie header, in Rails adapter, compatible with current Rack spec [Pedro Belo]
[#73, state:resolved]
http://github.com/macournoyer/th...

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »