Thin Thin → Future

Comments and changes to this ticket

• 

  macournoyer September 28th, 2009 @ 10:18 AM

  • State changed from “new” to “invalid”

  rack.errors is set to STDERR. It's like doing STDERR.to_json

  I guess you could set rack.errors to nil before doing that or create another hash w/ only the keys you want, or do something like:

  request.env.keys.sort.inject({}) {|e,(k,v)| e[k] = v.to_s }.to_json
  

• You flagged this item as spam.
  

  Greg Hazel September 28th, 2009 @ 11:03 AM

  Isn't there a better place for than sort of variable than env? It would be neat it the environment was entirely made of strings, like a shell environment.

• 

  macournoyer September 28th, 2009 @ 12:09 PM

  That's the Rack environment, nothing to do w/ shell env. Rack env is the
  only way to pass data around from request to response across apps and
  middlewares. Restricting to strings would be uselessly restrictive and
  degrade performance.

• You flagged this item as spam.
  

  Greg Hazel September 28th, 2009 @ 12:20 PM

  It is very related to the CGI environment variables, which have classically been strings since they were passed by the shell. The Rack parameters which are not strings have been conflated with the CGI parameters. This makes the hash difficult to serialize, when the rack variables should not be passed through a CGI-like interface.

  There are many options for improving this situation:

  1) Have "request.rack" separate from "request.env"

  2) Have "request.env['rack']" contain a hash of all the rack-related variables

  3) Have "request.env['cgi']" contain all the CGI-like environment variables