Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Does not work with Rails 3

#138

There is a detection to see if the rails app is rack based, which is too naive.

In lib/rack/adapter/rails.rb:

  def rack_based?
    rails_version = ::Rails::VERSION
    rails_version::MAJOR >= 2 && rails_version::MINOR >= 2 && rails_version::TINY >= 3
  end

In rails 2.3.8 (for example), we get true && true && true.

In rails 3.0.0, we get true && false && false, which means it thinks the rails isn't rack based.

Could we check for a config.ru in rails root instead?

Or maybe, if we detect rails 3, skip all the rails stuff, and just treat it like a rack app.

Reported by jammy · September 16th, 2010 @ 06:33 PM

State: invalid
Milestone: none
Assigned to: macournoyer macournoyer

Activity

  1. macournoyer
    macournoyer
    • State changed from new to invalid

    :D

    September 17th, 2010 @ 08:50 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.