-s directive not saved on `thin config`
-
macournoyer- Milestone set to 0.7.0
- State changed from new to open
nice catch James, seems to be the only option not saved to the config file. I'll fix that.
-
Matt ToddThe problem is that Controllers::Cluster#initialize deletes the :servers key from @options and stores it in @size.
One potential solution would be to not delete :servers if the command is 'config'... but that value isn't immediately available in Controllers::Cluster#initialize.
Alternatively, one solution could simply be to have a little wrapper Controllers::Cluster#config method that adds :servers back into @options.
But, now you know why it's being left out.
-
Matt Todd
The problem is that Controllers::Cluster#initialize deletes the :servers key from @options and stores it in @size.
One potential solution would be to not delete :servers if the command is 'config'... but that value isn't immediately available in Controllers::Cluster#initialize.
Alternatively, one solution could simply be to have a little wrapper Controllers::Cluster#config method that adds :servers back into @options.
But, now you know why it's being left out.
-
macournoyer
- State changed from open to resolved
Fixed in http://github.com/macournoyer/th...
I removed the code deleting the options and just removed them before sending it as a command to individual servers. Let me know what you think Matt.
and thx for reporting James.
-
Matt Todd
Seems good to me, considering it's a bit more forward-thinking so if you have other options you need to exclude later on, it's easy to update.
Nice and simple solution.
-
Matt Todd
(Sorry for the double post... apparently had network problems when I posted it so didn't realize it went through the first time.)
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.