Set-Cookie header incompatible with current Rack spec
Reported by Pedro Belo | June 30th, 2008 @ 04:36 PM | in 1.0
Using Thin + Rack::Adapter::Rails + Lint won't work if you have two cookies being set in the same response.
The problem is Rack::Adapter::Rails is joining the cookies with a newline, which is not accepted in the current Lint implementation.
Here's the original discussion in rack-devel
And here's a small patch to keep the Set-Cookie header as one array
Comments and changes to this ticket
-
macournoyer July 1st, 2008 @ 09:47 AM
- State changed from “new” to “open”
- Milestone changed from “Future” to “1.0”
-
macournoyer July 1st, 2008 @ 09:47 AM
thx for the patch Pedro, I'll apply and test when I get a minute
-
macournoyer July 1st, 2008 @ 10:51 PM
hm not sure about it. Like christian said:
"Set-Cookie" => [cookie1.to_s, cookie2.to_s] works in current Rack. In future Racks (for 1.9 support, not yet fully specified), the newline is the correct way.The newline is the correct way in 1.9, not sure if this is gonna end up the correct way for both version.
-
macournoyer July 14th, 2008 @ 12:03 AM
- State changed from “open” to “resolved”
(from [34da9ea800d4667a8a15700610ffc9fff71b9806]) Make Set-Cookie header, in Rails adapter, compatible with current Rack spec [Pedro Belo]
[#73, state:resolved]
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
macournoyer
Pedro Belo