Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

[PULL] A bunch of minor improvements

#78

Marc,

I've been reading Thin sources recently and noticed that some minor improvements can be done here and there (from not rescuing Object to doc touch ups). I'd tag those changes as "usability" :)

Can you pull from git://github.com/michaelklishin/thin.git please?

By the way, none of people in Merb community could tell why rescue Object was used, maybe I am missing something. If you want me to correct something, let me know.

Reported by Michael Klishin (antares) · August 2nd, 2008 @ 10:21 AM

State: resolved
Milestone: 1.0
Assigned to: macournoyer macournoyer

Activity

  1. macournoyer
    macournoyer
    • State changed from new to open
    • Milestone changed from Future to 1.0

    omg! thx a lot Michael for cleaning things up!

    Indeed using rescue Object was useless, maybe I though that some weird errors class did not inherit from Exception...

    I'll review and pull tonight.

    August 2nd, 2008 @ 10:42 AM

  2. Michael Klishin (antares)
    Michael Klishin (antares)

    Thanks. By the way, what you think about using YARD for documentation?

    August 2nd, 2008 @ 10:45 AM

  3. macournoyer
    macournoyer
    • State changed from open to resolved

    pulled

    Never used it, but looks pretty cool! If you wanna convert doc to use YARD, I'm ok w/ this.

    Will I be able to customize the style like I did w/ rdoc (http://code.macournoyer.com/thin... ?

    thx again Michael!

    August 2nd, 2008 @ 10:53 AM

  4. Michael Klishin (antares)
    Michael Klishin (antares)

    I think so. I will keep this requirement of yours in mind before I do anything :)

    August 2nd, 2008 @ 11:03 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.