[PULL] A bunch of minor improvements
Reported by Michael Klishin (antares) | August 2nd, 2008 @ 10:21 AM | in 1.0
Marc,
I've been reading Thin sources recently and noticed that some minor improvements can be done here and there (from not rescuing Object to doc touch ups). I'd tag those changes as "usability" :)
Can you pull from git://github.com/michaelklishin/thin.git please?
By the way, none of people in Merb community could tell why rescue Object was used, maybe I am missing something. If you want me to correct something, let me know.
Comments and changes to this ticket
-
macournoyer August 2nd, 2008 @ 10:42 AM
- State changed from “new” to “open”
- Milestone changed from “Future” to “1.0”
omg! thx a lot Michael for cleaning things up!
Indeed using rescue Object was useless, maybe I though that some weird errors class did not inherit from Exception...
I'll review and pull tonight.
-
Michael Klishin (antares) August 2nd, 2008 @ 10:45 AM
Thanks. By the way, what you think about using YARD for documentation?
-
macournoyer August 2nd, 2008 @ 10:53 AM
- State changed from “open” to “resolved”
pulled
Never used it, but looks pretty cool! If you wanna convert doc to use YARD, I'm ok w/ this.
Will I be able to customize the style like I did w/ rdoc (http://code.macournoyer.com/thin... ?
thx again Michael!
-
Michael Klishin (antares) August 2nd, 2008 @ 11:03 AM
I think so. I will keep this requirement of yours in mind before I do anything :)
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
macournoyer
Michael Klishin (antares)