[PULL] Rails 2.1 uses new method to set relative_url_root

#85

Please pull from seriph/thin

This patch fixes a warning when using a prefix with Rails 2.1.1 or greater.


DEPRECATION WARNING: ActionController::AbstractRequest.relative_url_root= has been renamed.You can now set it with config.action_controller.relative_url_root=  See http://www.rubyonrails.org/deprecation for details. (called from load_application at /Library/Ruby/Gems/1.8/gems/thin-1.0.0/lib/rack/adapter/rails.rb:34)

Although this warning says it's a "deprecation warning" it appears to break the prefix functionality entirely! This fix also supports the older rails method at the same time.

(If you look on that github commit, the author and commiter are actually both me but I changed my user.email setting so it got confused, sorry about that.)

Reported by Chris Cherry · October 17th, 2008 @ 02:46 PM

Activity

macournoyer
- State changed from new to resolved
(from [4d224bd3fe0824387da3cbb5390a02a8bd775c28]) Add CHANGELOG entry for last merge [#85 [PULL] Rails 2.1 uses new method to set relative_url_root state:resolved] http://github.com/macournoyer/th...

October 21st, 2008 @ 11:20 PM
macournoyer
- Milestone changed from Future to 1.1
Thx for the patch Chris!

October 21st, 2008 @ 11:29 PM
macournoyer
(from [20a46fbc6da8bd603e1e99ee760392abdbafc067]) Merge branch 'master' into async_for_rack
- master: Set RACK_ENV based on environment option when loading rackup file [Curtis Summers] [#83 set RACK_ENV based on environment option state:resolved] Add CHANGELOG entry for last merge [#85 [PULL] Rails 2.1 uses new method to set relative_url_root state:resolved] Add more sites to users page Support new Rails 2.1.1 method of setting relative_url_root as well as older Rails via a respond_to? check Rails now uses ActionController::Base.relative_url_root to set relative_url_root. http://github.com/macournoyer/th...
March 16th, 2009 @ 09:45 PM
John
Mit Verlaub, Casinos können eine Geldmaschine fürs Leben sein. Ich empfehle dringend den Besuch eines syndicate casino Online-Casinos für das beste Spielerlebnis, sagte er, Wenn Sie Ihren Job aufgeben und Ihren Lebensunterhalt mit Casinospielen verdienen wollen, ist dies der richtige Weg! Sie werden mir vielleicht nicht glauben https://syndicatecasino.at/

November 29th, 2023 @ 03:45 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.