PATCH: Compatibility macros for Ruby 1.8.5
Reported by Wincent Colaiuta | February 29th, 2008 @ 09:17 AM | in 0.7.1
Ruby 1.8.5 compatibility came up in this thread over at Google groups:
http://groups.google.com/group/thin-ruby/browse_thread/thread/5e0eb...
Here is a patch making Thin buildable on 1.8.5:
Also attaching it.
I think Ruby 1.8.5 compatibility is going to be important for a lot of enterprise users. For me the main reason I want to do this is that my platform, Red Hat Enterprise Linux ships with Ruby 1.8.5; Red Hat is going to support RHEL 5.1 up to 2014, and that means they'll patch Ruby 1.8.5 with security fixes for another 6 years, but they won't upgrade to post-1.8.5.
I haven't yet looked into whether the RHEL Ruby installation includes a fix for the CGI multipart issue.
Comments and changes to this ticket
-
Wincent Colaiuta February 29th, 2008 @ 09:17 AM
- no changes were found...
-
macournoyer February 29th, 2008 @ 10:05 AM
- Milestone set to “0.8.0”
- State changed from “new” to “open”
nice job Wincent, I'll check that out and maybe require the cgi_multipart_eof_fix if needed.
-
macournoyer February 29th, 2008 @ 10:33 AM
I see no other way then looking at the Ruby version number (apply of < 1.8.6).
I don't think it you cause any trouble if we require the gem even if the Ruby version was already patched.
Let me know if you got a better solution.
-
macournoyer March 2nd, 2008 @ 02:56 PM
- Milestone changed from “0.8.0” to “0.7.1”
- State changed from “open” to “resolved”
Applied http://github.com/macournoyer/th...
Also I loaded cgi_multipart_eof_fix if Ruby 1.8.5, reopen if you have a better solution
thx for the patch!
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Cheah Chu Yeow
macournoyer